Skip to content

cudaPackages.autoAddCudaCompatRunpath: badPlatforms broken#405031

Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom
SomeoneSerge:refactor/cuda/meta.unsupported
May 7, 2025
Merged

cudaPackages.autoAddCudaCompatRunpath: badPlatforms broken#405031
ConnorBaker merged 1 commit intoNixOS:masterfrom
SomeoneSerge:refactor/cuda/meta.unsupported

Conversation

@SomeoneSerge
Copy link
Contributor

@SomeoneSerge SomeoneSerge commented May 7, 2025

For consistency with other packages and for meta.unsupported

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: cuda Parallel computing platform and API label May 7, 2025
SomeoneSerge
SomeoneSerge commented May 7, 2025
View reviewed changes
pkgs/development/cuda-modules/packages/autoAddCudaCompatRunpath/package.nix Outdated
Comment on lines 18 to 19
Copy link
Contributor Author

@SomeoneSerge SomeoneSerge May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumed not an issue because this shouldn't be evaluated when meta.unsupported

@SomeoneSerge
cudaPackages.autoAddCudaCompatRunpath: badPlatforms broken
f5c6c16 
For consistency with other packages and for meta.unsupported
@SomeoneSerge SomeoneSerge force-pushed the refactor/cuda/meta.unsupported branch from b8bd6fc to f5c6c16 Compare May 7, 2025 19:34
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2025
GaetanLepage
GaetanLepage approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@ConnorBaker ConnorBaker self-assigned this May 7, 2025
@ConnorBaker ConnorBaker moved this from New to 🔖 Awaits the merge in CUDA Team May 7, 2025
@ConnorBaker ConnorBaker merged commit a481c95 into NixOS:master May 7, 2025
24 of 28 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Awaits the merge to ✅ Done in CUDA Team May 7, 2025
@trofi
Copy link
Contributor

trofi commented May 13, 2025

Bisect says that direct evaluation of an attribute fails now as it's not guarded by a platform check:

$ nix eval --impure --expr 'with import ./. {}; cudaPackages_11_0.autoAddCudaCompatRunpath.libcudaPath'

evaluation warning: CUDA versions older than 12.0 will be removed in Nixpkgs 25.05; see the 24.11 release notes for more information
error:
       … while evaluating the attribute 'autoAddCudaCompatRunpath.libcudaPath'
         at /tmp/nixpkgs/pkgs/development/cuda-modules/packages/autoAddCudaCompatRunpath/package.nix:16:5:
           15|   substitutions = {
           16|     libcudaPath = "${cuda_compat}/compat";
             |     ^
           17|   };

       … while evaluating a path segment
         at /tmp/nixpkgs/pkgs/development/cuda-modules/packages/autoAddCudaCompatRunpath/package.nix:16:20:
           15|   substitutions = {
           16|     libcudaPath = "${cuda_compat}/compat";
             |                    ^
           17|   };

       error: cannot coerce null to a string: null

@trofi
Copy link
Contributor

trofi commented May 13, 2025

Proposed a simple eval fix as:

@SomeoneSerge SomeoneSerge mentioned this pull request May 13, 2025
Merged
13 tasks
@SomeoneSerge
Copy link
Contributor Author

SomeoneSerge commented May 13, 2025

Thanks!

This was the intended effect, although now I'm reconsidering my premises. I meant to leave just enough logic for the derivation to pass CI checks. Maybe we should enforce a stricter standard, because that'd improve the developer experience: Connor already started this conversation in #406668 (comment), let's proceed there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConnorBaker ConnorBaker ConnorBaker approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

@ConnorBaker ConnorBaker

Labels

6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

CUDA Team
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SomeoneSerge @trofi @ConnorBaker @GaetanLepage